Bare except Exception handlers silently swallow errors in keyword_extractor.py #4

New Issue

llabeyrie · 2026-03-19T17:29:52Z

llabeyrie commented

2026-03-19 17:29:52 +00:00

Description

keyword_extractor.py lines 202 and 211 use bare except Exception handlers that silently return empty results:

try:
    import yake
except Exception:       # line 202 — catches ALL exceptions
    return {}

try:
    extractor = yake.KeywordExtractor(...)
except Exception:       # line 211 — catches ALL exceptions
    return {}

Problems

Catches KeyboardInterrupt, MemoryError, SystemExit and other critical exceptions
Silently returns {} with no logging — impossible to debug
A legitimate YAKE misconfiguration (wrong params, version incompatibility) would be invisible

Fix

try:
    import yake
except ImportError:
    logger.warning("yake not installed, skipping relevance scoring")
    return {}

try:
    extractor = yake.KeywordExtractor(...)
except (ValueError, TypeError) as e:
    logger.warning("YAKE extraction failed: %s", e)
    return {}

## Description `keyword_extractor.py` lines 202 and 211 use bare `except Exception` handlers that silently return empty results: ```python try: import yake except Exception: # line 202 — catches ALL exceptions return {} try: extractor = yake.KeywordExtractor(...) except Exception: # line 211 — catches ALL exceptions return {} ``` ### Problems - Catches `KeyboardInterrupt`, `MemoryError`, `SystemExit` and other critical exceptions - Silently returns `{}` with no logging — impossible to debug - A legitimate YAKE misconfiguration (wrong params, version incompatibility) would be invisible ### Fix ```python try: import yake except ImportError: logger.warning("yake not installed, skipping relevance scoring") return {} try: extractor = yake.KeywordExtractor(...) except (ValueError, TypeError) as e: logger.warning("YAKE extraction failed: %s", e) return {} ```

llabeyrie added the bug priority: high labels 2026-03-19 17:31:39 +00:00

llabeyrie referenced this issue from a commit

2026-03-19 18:32:15 +00:00

Narrow bare except handlers in keyword_extractor.py

llabeyrie referenced a pull request that will close this issue

2026-03-19 18:32:25 +00:00

Fix bare except handlers in keyword_extractor.py #20

llabeyrie closed this issue

2026-03-19 18:39:36 +00:00

Sign in to join this conversation.